Make target pointer width in target json an integer #144443

WaffleLapkin · 2025-07-25T10:20:13Z

r? Noratrieb
cc @RalfJung (https://github.com/rust-lang/rust/pull/142352/files#r2230380120)

try-job: x86_64-rust-for-linux

rustbot · 2025-07-25T10:20:18Z

Noratrieb is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2025-07-25T10:20:22Z

This PR modifies run-make tests.

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Noratrieb

I'm unsure if it's worth breaking everyone over such a minor improvement.. maybe? maybe not?

Noratrieb · 2025-07-25T10:32:18Z

I'm inclined to say yes, but it would probably be good to get this merged today so it can be in the same nightly as the other breaking change instead of two consecutive nightlies (it would also be fine to do that, but less cool)

RalfJung · 2025-07-25T11:39:31Z

I'm unsure if it's worth breaking everyone over such a minor improvement.. maybe? maybe not?

We already did that with #144443... the current state is just inconsistent.

But, no strong opinion.

WaffleLapkin · 2025-07-25T11:59:57Z

@Noratrieb what's the other breaking change? #142352 has been merged for over a month..

RalfJung · 2025-07-25T13:31:22Z

@Noratrieb what's the other breaking change? #142352 has been merged for over a month..

Uh, but then why did Miri CI only start failing today?

Something changed in 9748d87...b56aaec.

RalfJung · 2025-07-25T13:36:24Z

The breaking change was probably #144218.

src/tools/compiletest/src/common.rs

WaffleLapkin · 2025-07-25T13:41:32Z

The only relevant change I see is #144218, but that doesn't explain anything, it should have been failing with #142352, I don't see how it could have accepted c-int-width being a string...

RalfJung · 2025-07-25T13:44:17Z

It might be that the field of wrong type just got ignored, which is exactly why Nora ported this to serde.

WaffleLapkin · 2025-07-25T13:47:32Z

You are right indeed. The code in #142352:

                if let Some(s) = obj.remove(name).and_then(|b| b.as_u64()) {
                    base.$key_name = s as $int_ty;
                }

and_then(|b| b.as_u64()) makes it so non-integers are ignored.

compiler/rustc_target/src/spec/mod.rs

This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two temporary commits -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2]. Link: rust-lang#144443 [1] Link: rust-lang#145928 [2] Signed-off-by: Miguel Ojeda <[email protected]>

This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to be merged upstream -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2]. Link: rust-lang#144443 [1] Link: rust-lang#145928 [2] Signed-off-by: Miguel Ojeda <[email protected]>

CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to be merged upstream -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2]. Link: rust-lang#144443 [1] Link: rust-lang#145928 [2] r? `@lqd` `@Kobzol` try-job: x86_64-rust-for-linux `@rustbot` label A-rust-for-linux `@bors` try

CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to be merged upstream -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2]. Link: rust-lang#144443 [1] Link: rust-lang#145928 [2] r? ``@lqd`` ``@Kobzol`` try-job: x86_64-rust-for-linux ``@rustbot`` label A-rust-for-linux ``@bors`` try

See rust-lang/rust#144443

Rollup merge of #146154 - ojeda:rfl, r=lqd CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits This upgrades the Rust CI from v6.16-rc1 plus a temporary commit for the >= 1.91 target spec [1] to v6.17-rc3 with two commits pending to be merged upstream -- one for the same target spec format change [1] and another for the `file_as_c_str` change [2]. Link: #144443 [1] Link: #145928 [2] r? ``@lqd`` ``@Kobzol`` try-job: x86_64-rust-for-linux ``@rustbot`` label A-rust-for-linux ``@bors`` try

…r-width, r=Noratrieb Make target pointer width in target json an integer r? Noratrieb cc `@RalfJung` (https://github.com/rust-lang/rust/pull/142352/files#r2230380120) try-job: x86_64-rust-for-linux

commit 8851e27 upstream. Starting with Rust 1.91.0 (expected 2025-10-30), the target spec format has changed the type of the `target-pointer-width` key from string to integer [1]. Thus conditionally use one or the other depending on the version. Cc: Waffle Maybe <[email protected]> Link: rust-lang/rust#144443 [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>

commit 8851e27d2cb947ea8bbbe8e812068f7bf5cbd00b upstream. Starting with Rust 1.91.0 (expected 2025-10-30), the target spec format has changed the type of the `target-pointer-width` key from string to integer [1]. Thus conditionally use one or the other depending on the version. Cc: Waffle Maybe <[email protected]> Link: rust-lang/rust#144443 [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> (cherry picked from commit 17cab7b45f4db7fcc59420407e49ed66494a556c)

Starting with Rust 1.91.0 (expected 2025-10-30), the target spec format has changed the type of the `target-pointer-width` key from string to integer [1]. Thus conditionally use one or the other depending on the version. Cc: Waffle Maybe <[email protected]> Link: rust-lang/rust#144443 [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>

rust-lang/rust#144443

* Handle Rust >= 1.91 change to `target-pointer-width` JSON type rust-lang/rust#144443 * Update changelog

commit 8851e27d2cb947ea8bbbe8e812068f7bf5cbd00b upstream. Starting with Rust 1.91.0 (expected 2025-10-30), the target spec format has changed the type of the `target-pointer-width` key from string to integer [1]. Thus conditionally use one or the other depending on the version. Cc: Waffle Maybe <[email protected]> Link: rust-lang/rust#144443 [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> (cherry picked from commit 17cab7b45f4db7fcc59420407e49ed66494a556c)

Starting with Rust 1.91.0 (expected 2025-10-30), the target spec format has changed the type of the `target-pointer-width` key from string to integer [1]. Thus conditionally use one or the other depending on the version. Cc: Waffle Maybe <[email protected]> Link: rust-lang/rust#144443 [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>

rust-lang/rust#144443

commit 8851e27d2cb947ea8bbbe8e812068f7bf5cbd00b upstream. Starting with Rust 1.91.0 (expected 2025-10-30), the target spec format has changed the type of the `target-pointer-width` key from string to integer [1]. Thus conditionally use one or the other depending on the version. Cc: Waffle Maybe <[email protected]> Link: rust-lang/rust#144443 [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> (cherry picked from commit 17cab7b45f4db7fcc59420407e49ed66494a556c) Signed-off-by: Harshit Mogalapalli <[email protected]>

* Handle Rust >= 1.91 change to `target-pointer-width` JSON type rust-lang/rust#144443 * Update changelog

Starting with Rust 1.91.0 (expected 2025-10-30), the target spec format has changed the type of the `target-pointer-width` key from string to integer [1]. Thus conditionally use one or the other depending on the version. Cc: Waffle Maybe <[email protected]> Link: rust-lang/rust#144443 [1] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>

koute · 2025-10-09T12:00:36Z

Just wanted to say, I'm really disappointed that such a trivial breaking charge was merged without any deprecation period and without making it just accept both forms for compatibility (which also would have been trivial), which would save a lot of pain for a lot of people. Not everyone wants to live on the bleeding edge of MSRV, and some people care that their software works on a wide range of rustc versions.

RalfJung · 2025-10-09T13:08:28Z

Hm yeah maybe we should have accepted both forms for a while. OTOH, without a lint hardly anyone would have noticed so there would still have been breakage later when the old form is removed, and a lint would have been more extra work. We have always been very clear that there is no stability on nightly.

koute · 2025-10-09T21:18:41Z

Be that as it may, this is just pretty much an aesthetic change with no real practical benefit besides "it's nicer this way", it was "stable" and worked for years (even if not officially stabilized), there's no non-nightly alternative so those who need it are forced to use it, and many people depend on it. Doesn't the cost-benefit ratio here seem very skewed to you here? Sure, it would be extra work to make it temporarily accept both forms and add a lint for a few releases, but that extra work wasn't eliminated, just multiplied and pushed somewhere else, because now everyone who uses this and doesn't want to require a bleeding edge MSRV will now have to do the extra work to autodetect the compiler and support both.

Anyway, I apologize if I may seem blunt; I know you're doing a thankless job. I just wish this would have been handled better; I suppose it's too late now to do anything about it?

rustbot assigned Noratrieb Jul 25, 2025

Noratrieb reviewed Jul 25, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

WaffleLapkin force-pushed the integer-target-pointer-width branch from bb5b5c5 to 283f21b Compare July 25, 2025 11:55

This comment has been minimized.

Sign in to view

WaffleLapkin force-pushed the integer-target-pointer-width branch from 283f21b to 267f0bd Compare July 25, 2025 12:35

This comment has been minimized.

Sign in to view

WaffleLapkin force-pushed the integer-target-pointer-width branch from b64ab4a to b2871e5 Compare July 25, 2025 13:33

RalfJung reviewed Jul 25, 2025

View reviewed changes

src/tools/compiletest/src/common.rs Outdated Show resolved Hide resolved

RalfJung reviewed Jul 25, 2025

View reviewed changes

compiler/rustc_target/src/spec/mod.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

jieyouxu self-assigned this Jul 25, 2025

jieyouxu mentioned this pull request Jul 28, 2025

Consider compiletest a staged ToolStd tool #144563

Closed

phil-opp mentioned this pull request Sep 2, 2025

Fix: target-pointer-width field now expects an integer rust-osdev/bootloader#516

Merged

ojeda mentioned this pull request Sep 3, 2025

CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits #146154

Merged

phil-opp added a commit to rust-osdev/bootloader that referenced this pull request Sep 3, 2025

Fix(v0.9): target-pointer-width field now expects an integer

8fd07ad

See rust-lang/rust#144443

This was referenced Sep 3, 2025

Fix(v0.9): target-pointer-width field now expects an integer rust-osdev/bootloader#518

Merged

Fix: target-pointer-width field now expects an integer phil-opp/blog_os#1436

Merged

cmichi added a commit to use-ink/cargo-contract that referenced this pull request Sep 11, 2025

Handle Rust >= 1.91 change to target-pointer-width JSON type

6cf90d2

rust-lang/rust#144443

cmichi added a commit to use-ink/cargo-contract that referenced this pull request Sep 11, 2025

Handle Rust >= 1.91 change to target-pointer-width JSON type

760ebff

rust-lang/rust#144443

cmichi mentioned this pull request Sep 11, 2025

Handle Rust >= 1.91 change of target-pointer-width JSON type use-ink/cargo-contract#2131

Merged

cmichi added a commit to use-ink/cargo-contract that referenced this pull request Sep 12, 2025

Handle Rust >= 1.91 change of target-pointer-width JSON type (#2131)

758953d

* Handle Rust >= 1.91 change to `target-pointer-width` JSON type rust-lang/rust#144443 * Update changelog

cmichi added a commit to use-ink/polkavm that referenced this pull request Oct 2, 2025

Handle Rust >= 1.91 change to target-pointer-width JSON type

19d9e95

rust-lang/rust#144443

cmichi mentioned this pull request Oct 2, 2025

Handle Rust >= 1.91 change of target-pointer-width JSON type paritytech/polkavm#341

Open

suiiancm added a commit to suiiancm/cargo-contract that referenced this pull request Oct 4, 2025

Handle Rust >= 1.91 change of target-pointer-width JSON type (#2131)

8189d10

* Handle Rust >= 1.91 change to `target-pointer-width` JSON type rust-lang/rust#144443 * Update changelog

Make target pointer width in target json an integer #144443

Make target pointer width in target json an integer #144443

Conversation

WaffleLapkin commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 25, 2025

Uh oh!

rustbot commented Jul 25, 2025

Uh oh!

Noratrieb left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Noratrieb commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfJung commented Jul 25, 2025

Uh oh!

WaffleLapkin commented Jul 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

RalfJung commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfJung commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

WaffleLapkin commented Jul 25, 2025

Uh oh!

RalfJung commented Jul 25, 2025

Uh oh!

WaffleLapkin commented Jul 25, 2025

Uh oh!

Uh oh!

This comment has been minimized.

koute commented Oct 9, 2025

Uh oh!

RalfJung commented Oct 9, 2025 via email

Uh oh!

koute commented Oct 9, 2025

Uh oh!

Uh oh!

WaffleLapkin commented Jul 25, 2025 •

edited

Loading

Noratrieb commented Jul 25, 2025 •

edited

Loading

RalfJung commented Jul 25, 2025 •

edited

Loading

RalfJung commented Jul 25, 2025 •

edited

Loading